Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: correct typos about Dtk::Gui::DDciIcon::IconAttribute #202

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: correct typos about Dtk::Gui::DDciIcon::IconAttribute #202

wants to merge 1 commit into from

Conversation

felixonmars
Copy link
Member

Log:

@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: felixonmars

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Sep 30, 2023

Doc Check bot
🟡 some documents missing!

File Line Symbol
include/util/ddciicon.h 88 Dtk::Gui::DDciIcon::Q_FLAGS

kegechen
kegechen reviewed Oct 9, 2023
View reviewed changes
Copy link
Contributor

@kegechen kegechen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

会引起接口变动，谨慎点
是否废弃旧的然后增加新的？
dtk6 统一删除typo接口

asterwyx
asterwyx requested changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@asterwyx asterwyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

涉及到api变动需要以兼容的方式进行修改，建议在DTK5的环境下添加using IconAttibute=IconAttribute;

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jan 9, 2024

TAG Bot

New tag: 5.6.21
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #214

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jan 12, 2024

TAG Bot

New tag: 5.6.22
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #219

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Mar 11, 2024

TAG Bot

New tag: 5.6.25
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #227

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Mar 27, 2024

TAG Bot

New tag: 5.6.26
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #229

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Apr 23, 2024

TAG Bot

New tag: 5.6.27
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #233

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Apr 30, 2024

TAG Bot

New tag: 5.6.28
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #237

@deepin-bot
Copy link
Contributor

deepin-bot bot commented May 16, 2024

TAG Bot

New tag: 5.6.29
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #239

@deepin-bot
Copy link
Contributor

deepin-bot bot commented May 31, 2024

TAG Bot

New tag: 5.6.30
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #241

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jun 27, 2024

TAG Bot

New tag: 5.6.31
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #243

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jul 10, 2024

TAG Bot

New tag: 5.6.32
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #245

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Aug 21, 2024

TAG Bot

New tag: 5.6.34
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #251

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Oct 31, 2024

TAG Bot

New tag: 5.7.1
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #256

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Nov 15, 2024

TAG Bot

New tag: 5.7.2
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #271

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kegechen kegechen kegechen left review comments

@asterwyx asterwyx asterwyx requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@felixonmars @deepin-ci-robot @kegechen @asterwyx